-
-
Notifications
You must be signed in to change notification settings - Fork 112
feat: Add templates for xunit.v3 #1634
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Should we upgrade dependencies on the other templates too? |
Is there any conflict between bUnits TestContext and Xunits? Haven't tested yet myself. |
My understanding is that you either use the static object aka |
Sure why not |
e774a7e
to
043b206
Compare
e4bd142
to
7a366f2
Compare
7a366f2
to
b35b84c
Compare
I did the following:
|
You were right - there are conflicts. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Excellent
Than we can change our default import to be:
|
You mean for that specific template? It might be confusing and less verbose (especially regarding all our docs). |
@egil Can we merge this or do you want to rename |
An important point of having a template is that works out of the box for the users. For now, I guess we can just have test class examples inherit from the fqns, e.g. |
I absolutely agree - and if it wouldn't be for |
Added another template for
xunit.v3
.